[PATCH] D23339: Don't import variadic functions

[Easwaran Raman via llvm-commits]

On Wed, Aug 10, 2016 at 2:44 PM, Piotr Padlewski <piotr.padlewski at gmail.com>
wrote:

> Prazek added a comment.
>
> In https://reviews.llvm.org/D23339#511891, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D23339#511890, @eraman wrote:
> >
> > > In https://reviews.llvm.org/D23339#511869, @mehdi_amini wrote:
> > >
> > > > LGTM, thanks.
> > > >  We probably need to review other properties of function that
> prevents them from being inlined.
> > >
> > >
> > > This check should be eventually moved to InlineCost so that importer
> and inliner are out of sync. For now, a FIXME should be useful.
> >
> >
> > Very good point indeed.
>
>
> So we could check all attributes but they are so not frequent that it wont
> make huge difference like this one. If the checks are in O(1) then it
> probably make sense to move them eventually, but things like traversing all
> instructions to check if function is recursive and other would not make
> much sense as these functions or instructions are not that frequent (imho)
>
They are not frequent in Spec does not necessarily mean they are not useful
to check. In any case my point is that the logic should reside in
InlineCost where we could choose to do only the inexpensive checks (even if
it is just this one).


>
>
> https://reviews.llvm.org/D23339
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160810/715b6a4b/attachment.html>