[PATCH] D23339: Don't import variadic functions

[Piotr Padlewski via llvm-commits]

Prazek added a comment.

In https://reviews.llvm.org/D23339#511891, @mehdi_amini wrote:

> In https://reviews.llvm.org/D23339#511890, @eraman wrote:
>
> > In https://reviews.llvm.org/D23339#511869, @mehdi_amini wrote:
> >
> > > LGTM, thanks.
> > >  We probably need to review other properties of function that prevents them from being inlined.
> >
> >
> > This check should be eventually moved to InlineCost so that importer and inliner are out of sync. For now, a FIXME should be useful.
>
>
> Very good point indeed.


So we could check all attributes but they are so not frequent that it wont make huge difference like this one. If the checks are in O(1) then it probably make sense to move them eventually, but things like traversing all instructions to check if function is recursive and other would not make much sense as these functions or instructions are not that frequent (imho)


https://reviews.llvm.org/D23339