[llvm] r278162 - [ExecutionEngine] Disable weak symbol tests for COFF.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 13:48:22 PDT 2016


Author: lhames
Date: Tue Aug  9 15:48:22 2016
New Revision: 278162

URL: http://llvm.org/viewvc/llvm-project?rev=278162&view=rev
Log:
[ExecutionEngine] Disable weak symbol tests for COFF.

COFF doesn't support weak linkage on functions.

Modified:
    llvm/trunk/test/ExecutionEngine/MCJIT/Inputs/weak-function-2.ll
    llvm/trunk/test/ExecutionEngine/MCJIT/weak-function.ll
    llvm/trunk/test/ExecutionEngine/OrcMCJIT/Inputs/weak-function-2.ll
    llvm/trunk/test/ExecutionEngine/OrcMCJIT/weak-function.ll
    llvm/trunk/test/lit.cfg

Modified: llvm/trunk/test/ExecutionEngine/MCJIT/Inputs/weak-function-2.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/MCJIT/Inputs/weak-function-2.ll?rev=278162&r1=278161&r2=278162&view=diff
==============================================================================
--- llvm/trunk/test/ExecutionEngine/MCJIT/Inputs/weak-function-2.ll (original)
+++ llvm/trunk/test/ExecutionEngine/MCJIT/Inputs/weak-function-2.ll Tue Aug  9 15:48:22 2016
@@ -1,4 +1,4 @@
-define linkonce_odr i32 @baz() #0 {
+define weak i32 @baz() #0 {
 entry:
   ret i32 0
 }

Modified: llvm/trunk/test/ExecutionEngine/MCJIT/weak-function.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/MCJIT/weak-function.ll?rev=278162&r1=278161&r2=278162&view=diff
==============================================================================
--- llvm/trunk/test/ExecutionEngine/MCJIT/weak-function.ll (original)
+++ llvm/trunk/test/ExecutionEngine/MCJIT/weak-function.ll Tue Aug  9 15:48:22 2016
@@ -1,9 +1,12 @@
 ; RUN: lli -jit-kind=mcjit -extra-module %p/Inputs/weak-function-2.ll %s
+; REQUIRES: not_COFF
 ;
 ; Check that functions in two different modules agree on the address of weak
 ; function 'baz'
+; Testing on COFF platforms is disabled as COFF has no representation of 'weak'
+; linkage.
 
-define linkonce_odr i32 @baz() {
+define weak i32 @baz() {
 entry:
   ret i32 0
 }

Modified: llvm/trunk/test/ExecutionEngine/OrcMCJIT/Inputs/weak-function-2.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/OrcMCJIT/Inputs/weak-function-2.ll?rev=278162&r1=278161&r2=278162&view=diff
==============================================================================
--- llvm/trunk/test/ExecutionEngine/OrcMCJIT/Inputs/weak-function-2.ll (original)
+++ llvm/trunk/test/ExecutionEngine/OrcMCJIT/Inputs/weak-function-2.ll Tue Aug  9 15:48:22 2016
@@ -1,4 +1,4 @@
-define linkonce_odr i32 @baz() #0 {
+define weak i32 @baz() #0 {
 entry:
   ret i32 0
 }

Modified: llvm/trunk/test/ExecutionEngine/OrcMCJIT/weak-function.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/OrcMCJIT/weak-function.ll?rev=278162&r1=278161&r2=278162&view=diff
==============================================================================
--- llvm/trunk/test/ExecutionEngine/OrcMCJIT/weak-function.ll (original)
+++ llvm/trunk/test/ExecutionEngine/OrcMCJIT/weak-function.ll Tue Aug  9 15:48:22 2016
@@ -1,9 +1,12 @@
 ; RUN: lli -jit-kind=orc-mcjit -extra-module %p/Inputs/weak-function-2.ll %s
+; REQUIRES: not_COFF
 ;
 ; Check that functions in two different modules agree on the address of weak
-; function 'baz'
+; function 'baz'.
+; Testing on COFF platforms is disabled as COFF has no representation of 'weak'
+; linkage.
 
-define linkonce_odr i32 @baz() {
+define weak i32 @baz() {
 entry:
   ret i32 0
 }

Modified: llvm/trunk/test/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/lit.cfg?rev=278162&r1=278161&r2=278162&view=diff
==============================================================================
--- llvm/trunk/test/lit.cfg (original)
+++ llvm/trunk/test/lit.cfg Tue Aug  9 15:48:22 2016
@@ -357,6 +357,7 @@ if execute_external:
 # Others/can-execute.txt
 if sys.platform not in ['win32']:
     config.available_features.add('can-execute')
+    config.available_features.add('not_COFF')
 
 # Loadable module
 # FIXME: This should be supplied by Makefile or autoconf.




More information about the llvm-commits mailing list