[PATCH] D22975: Compute the Newton series natively

[Simon Pilgrim via llvm-commits]

RKSimon added a subscriber: RKSimon.
RKSimon added a reviewer: RKSimon.
RKSimon added a comment.

Please can you recreate the diff with context? svn diff --diff-cmd=diff -x -U999999


================
Comment at: llvm/test/CodeGen/X86/sqrt-fastmath.ll:42-45
@@ -41,6 +41,6 @@
 ; ESTIMATE-NEXT:    vmulss %xmm1, %xmm2, %xmm1
 ; ESTIMATE-NEXT:    vxorps %xmm2, %xmm2, %xmm2
-; ESTIMATE-NEXT:    vcmpeqss %xmm2, %xmm0, %xmm0
-; ESTIMATE-NEXT:    vandnps %xmm1, %xmm0, %xmm0
+; ESTIMATE-NEXT:    vcmpeqss %xmm2, %xmm0, %xmm2
+; ESTIMATE-NEXT:    vblendvps %xmm2, %xmm0, %xmm1, %xmm0
 ; ESTIMATE-NEXT:    retq
   %call = tail call float @__sqrtf_finite(float %f) #1
----------------
spatel wrote:
> No worries. Note that I've used a modified version of that script to generate checks for targets besides x86 - in case anyone would like to enhance the script and make test generation easier for AArch64. :)
As Sanjay said, the use of vblendvps over vandnps is a regression that could affect throughput quite badly.


Repository:
  rL LLVM

https://reviews.llvm.org/D22975