[PATCH] D23318: [PATCH] tsan: Remove __pointer_chk_guard at GLIBC_PRIVATE requirement for AArch64

[Renato Golin via llvm-commits]

rengolin added a comment.

Reading again, it seems you're just reimplementing a similar logic, with a known global, which is safer than relying on glibc's own copy. So, even for gcc using TSAN, there will be no deviation.

You're still relying on _ZN14__interception12real__setjmpE, but that's a public interface  so it should be OK, right?

Apart from the name nit, I have no real concern.

Cheers, 
Renato


================
Comment at: lib/tsan/rtl/tsan_rtl_aarch64.S:76
@@ -25,3 +75,3 @@
   // SP pointer mangling (see glibc setjmp)
-  adrp    x2, :got:__pointer_chk_guard
-  ldr     x2, [x2, #:got_lo12:__pointer_chk_guard]
+  adrp    x2, pointer_chk_guard
+  ldr     x2, [x2, #:lo12:pointer_chk_guard]
----------------
Maybe call it __tsan_pointer_chk_guard? 


https://reviews.llvm.org/D23318