[PATCH] D23318: [PATCH] tsan: Remove __pointer_chk_guard at GLIBC_PRIVATE requirement for AArch64
Adhemerval Zanella via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 9 11:26:10 PDT 2016
zatrazz added inline comments.
================
Comment at: lib/tsan/rtl/tsan_platform_linux.cc:273
@@ +272,3 @@
+
+ // GLIBC mangles the function pointers in jmp_buf (used in {set,long}*jmp
+ // functions) by XORing them with a random guard pointer. For AArch64 it
----------------
dvyukov wrote:
> I think this comment belongs to tsan_rtl_aarch64.S.
> This file is platform independent, and the things this comment talks about are all in tsan_rtl_aarch64.S.
Alright, I think I can just add a comment explaining this calls a arch-specific code to init the glibc guard pointer.
https://reviews.llvm.org/D23318
More information about the llvm-commits
mailing list