[PATCH] D23254: CodeView: extract the OMF Directory Header

[David Majnemer via llvm-commits]

On Mon, Aug 8, 2016 at 7:58 AM, Zachary Turner <zturner at google.com> wrote:

> Is this information described in the Microsoft github repository anywhere?


They have bits of it here:
https://github.com/Microsoft/microsoft-pdb/blob/e6b1dec61e154b568357537792e1d17a13525d5d/PDB/dbi/locator.h#L24

 and here:
https://github.com/Microsoft/microsoft-pdb/blob/e6b1dec61e154b568357537792e1d17a13525d5d/PDB/dbi/locator.cpp#L747


>
> On Sun, Aug 7, 2016 at 11:50 PM David Majnemer <david.majnemer at gmail.com>
> wrote:
>
>> majnemer added a subscriber: majnemer.
>>
>> ================
>> Comment at: lib/DebugInfo/CodeView/CVDebugRecord.cpp:14-21
>> @@ +13,10 @@
>> +
>> +const support::ulittle32_t OMF::Signature::PDB70Signature =
>> +    support::ulittle32_t(0x53445352); // RSDS
>> +const support::ulittle32_t OMF::Signature::PDB20Signature =
>> +    support::ulittle32_t(0x3031424e); // NB10
>> +const support::ulittle32_t OMF::Signature::CV50Signature =
>> +    support::ulittle32_t(0x3131424e); // NB11
>> +const support::ulittle32_t OMF::Signature::CV41Signature =
>> +    support::ulittle32_t(0x3930424e); // NB09
>> +
>> ----------------
>> This is pretty irregular, we usually have the constant have a normal
>> type.  I would expect this to be an enum.
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D23254
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160808/e00ac746/attachment.html>