<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 8, 2016 at 7:58 AM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Is this information described in the Microsoft github repository anywhere?</blockquote><div><br></div><div>They have bits of it here:</div><div><a href="https://github.com/Microsoft/microsoft-pdb/blob/e6b1dec61e154b568357537792e1d17a13525d5d/PDB/dbi/locator.h#L24">https://github.com/Microsoft/microsoft-pdb/blob/e6b1dec61e154b568357537792e1d17a13525d5d/PDB/dbi/locator.h#L24</a></div><div><br></div><div> and here:</div><div><a href="https://github.com/Microsoft/microsoft-pdb/blob/e6b1dec61e154b568357537792e1d17a13525d5d/PDB/dbi/locator.cpp#L747">https://github.com/Microsoft/microsoft-pdb/blob/e6b1dec61e154b568357537792e1d17a13525d5d/PDB/dbi/locator.cpp#L747</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Sun, Aug 7, 2016 at 11:50 PM David Majnemer <<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">majnemer added a subscriber: majnemer.<br>
<br>
================<br>
Comment at: lib/DebugInfo/CodeView/<wbr>CVDebugRecord.cpp:14-21<br>
@@ +13,10 @@<br>
+<br>
+const support::ulittle32_t OMF::Signature::PDB70Signature =<br>
+    support::ulittle32_t(<wbr>0x53445352); // RSDS<br>
+const support::ulittle32_t OMF::Signature::PDB20Signature =<br>
+    support::ulittle32_t(<wbr>0x3031424e); // NB10<br>
+const support::ulittle32_t OMF::Signature::CV50Signature =<br>
+    support::ulittle32_t(<wbr>0x3131424e); // NB11<br>
+const support::ulittle32_t OMF::Signature::CV41Signature =<br>
+    support::ulittle32_t(<wbr>0x3930424e); // NB09<br>
+<br>
----------------<br>
This is pretty irregular, we usually have the constant have a normal type.  I would expect this to be an enum.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D23254" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D23254</a><br>
<br>
<br>
<br>
</blockquote></div>
</div></div></blockquote></div><br></div></div>