[PATCH] D23223: [InstCombine] refactor ctlz/cttz folds (NFCI)
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 5 15:07:10 PDT 2016
spatel marked 2 inline comments as done.
================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:1107
@@ -1106,1 +1106,3 @@
+static Value *foldCttzCtlz(IntrinsicInst &II, InstCombiner &IC, bool IsTZ) {
+ Value *Op0 = II.getArgOperand(0);
----------------
majnemer wrote:
> Can't IsTZ be divined from the `II`?
Yep - that looks nicer.
================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:1110
@@ +1109,3 @@
+ // FIXME: Try to simplify vectors of integers.
+ IntegerType *IT = dyn_cast<IntegerType>(Op0->getType());
+ if (!IT)
----------------
majnemer wrote:
> `auto *`
Done.
https://reviews.llvm.org/D23223
More information about the llvm-commits
mailing list