[PATCH] D23223: [InstCombine] refactor ctlz/cttz folds (NFCI)

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 5 14:53:17 PDT 2016


majnemer added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:1107
@@ -1106,1 +1106,3 @@
 
+static Value *foldCttzCtlz(IntrinsicInst &II, InstCombiner &IC, bool IsTZ) {
+  Value *Op0 = II.getArgOperand(0);
----------------
Can't IsTZ be divined from the `II`?

================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:1110
@@ +1109,3 @@
+  // FIXME: Try to simplify vectors of integers.
+  IntegerType *IT = dyn_cast<IntegerType>(Op0->getType());
+  if (!IT)
----------------
`auto *`


https://reviews.llvm.org/D23223





More information about the llvm-commits mailing list