[PATCH] D23206: [ELF] - Linkerscript: do not define _edata, _end, _etext if SECTIONS is used.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 5 14:13:00 PDT 2016
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: ELF/Writer.cpp:602
@@ -597,1 +601,3 @@
+ if (!ScriptConfig->HasContents)
+ defineStandartSymbols<ELFT>(Symtab);
}
----------------
Can you inline this function? I think it is already well factored out, so we don't need to split it even more.
https://reviews.llvm.org/D23206
More information about the llvm-commits
mailing list