[PATCH] D21462: [PM] Make the the new pass manageg support fully generic extra arguments to run methods, both for transform passes and analysis passes.

[Chandler Carruth via llvm-commits]

On Thu, Aug 4, 2016 at 12:09 AM Sean Silva <chisophugis at gmail.com> wrote:

> silvas added a comment.
>
> In https://reviews.llvm.org/D21462#505454, @chandlerc wrote:
>
> > Ok, but I don't want to hold up progress waiting on a different design.
> In my opinion, it doesn't really make sense to pursue both of these
> directions concurrently in tree because of how much overlap they have and
> the fact that they seem likely to hold each other up.
>
>
> The current design of the analysis manager has a fatal bug (no dependency
> tracking). I'm fixing it. The bug is so fatal that the "new PM" cannot be
> run on any realistic workload without segfaulting or use-after-free. So the
> entirety of the "new PM" will be nothing but a toy (essentially dead code)
> until this is fixed.
>

So, I too would like to work on this, but I would like to actually put
together the real world pipeline that triggers the issue, and this patch is
in the critical path of this.


>
> Please bear with me as I fix it.
>

I don't think this is a legitimate reason to hold up a patch when this
patch has nothing to do with the bug in question....
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160804/23cb4bd9/attachment.html>