[llvm] r277690 - Revert "GVN-hoist: enable by default" & "Make GVN Hoisting obey optnone/bisect."

[Daniel Berlin via llvm-commits]

so here's the super-curious question in my mind:

Why didn't this break when this was enabled by default for like a month
before :)

It's not like this is the first time it was turned on.




On Wed, Aug 3, 2016 at 9:16 PM, Bruno Cardoso Lopes via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: bruno
> Date: Wed Aug  3 23:16:24 2016
> New Revision: 277690
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277690&view=rev
> Log:
> Revert "GVN-hoist: enable by default" & "Make GVN Hoisting obey
> optnone/bisect."
>
> This reverts commits r277685 & r277688. r277685 broke compiler-rt
> compilation
> http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_build/23335
> and r277685 is a followup from it.
>
> Modified:
>     llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp
>     llvm/trunk/test/Feature/optnone-opt.ll
>
> Modified: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=277690&r1=277689&r2=277690&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp (original)
> +++ llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp Wed Aug  3
> 23:16:24 2016
> @@ -138,8 +138,8 @@ static cl::opt<int> PreInlineThreshold(
>               "(default = 75)"));
>
>  static cl::opt<bool> EnableGVNHoist(
> -    "enable-gvn-hoist", cl::init(true), cl::Hidden,
> -    cl::desc("Enable the GVN hoisting pass (default = on)"));
> +    "enable-gvn-hoist", cl::init(false), cl::Hidden,
> +    cl::desc("Enable the experimental GVN Hoisting pass"));
>
>  PassManagerBuilder::PassManagerBuilder() {
>      OptLevel = 2;
>
> Modified: llvm/trunk/test/Feature/optnone-opt.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/optnone-opt.ll?rev=277690&r1=277689&r2=277690&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/Feature/optnone-opt.ll (original)
> +++ llvm/trunk/test/Feature/optnone-opt.ll Wed Aug  3 23:16:24 2016
> @@ -41,7 +41,6 @@ attributes #0 = { optnone noinline }
>  ; OPT-O1-DAG: Skipping pass 'Combine redundant instructions'
>  ; OPT-O1-DAG: Skipping pass 'Dead Store Elimination'
>  ; OPT-O1-DAG: Skipping pass 'Early CSE'
> -; OPT-O1-DAG: Skipping pass 'Early GVN Hoisting of Expressions'
>  ; OPT-O1-DAG: Skipping pass 'Jump Threading'
>  ; OPT-O1-DAG: Skipping pass 'MemCpy Optimization'
>  ; OPT-O1-DAG: Skipping pass 'Reassociate expressions'
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160803/d1cb8bcd/attachment.html>