<div dir="ltr">so here's the super-curious question in my mind:<br><br><div>Why didn't this break when this was enabled by default for like a month before :)</div><div><br></div><div>It's not like this is the first time it was turned on.</div><div><br><br><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 3, 2016 at 9:16 PM, Bruno Cardoso Lopes via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: bruno<br>
Date: Wed Aug  3 23:16:24 2016<br>
New Revision: 277690<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=277690&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=277690&view=rev</a><br>
Log:<br>
Revert "GVN-hoist: enable by default" & "Make GVN Hoisting obey optnone/bisect."<br>
<br>
This reverts commits r277685 & r277688. r277685 broke compiler-rt<br>
compilation <a href="http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_build/23335" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_build/23335</a><br>
and r277685 is a followup from it.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp<br>
    llvm/trunk/test/Feature/optnone-opt.ll<br>
<br>
Modified: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=277690&r1=277689&r2=277690&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=277690&r1=277689&r2=277690&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp Wed Aug  3 23:16:24 2016<br>
@@ -138,8 +138,8 @@ static cl::opt<int> PreInlineThreshold(<br>
              "(default = 75)"));<br>
<br>
 static cl::opt<bool> EnableGVNHoist(<br>
-    "enable-gvn-hoist", cl::init(true), cl::Hidden,<br>
-    cl::desc("Enable the GVN hoisting pass (default = on)"));<br>
+    "enable-gvn-hoist", cl::init(false), cl::Hidden,<br>
+    cl::desc("Enable the experimental GVN Hoisting pass"));<br>
<br>
 PassManagerBuilder::PassManagerBuilder() {<br>
     OptLevel = 2;<br>
<br>
Modified: llvm/trunk/test/Feature/optnone-opt.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/optnone-opt.ll?rev=277690&r1=277689&r2=277690&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/optnone-opt.ll?rev=277690&r1=277689&r2=277690&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Feature/optnone-opt.ll (original)<br>
+++ llvm/trunk/test/Feature/optnone-opt.ll Wed Aug  3 23:16:24 2016<br>
@@ -41,7 +41,6 @@ attributes #0 = { optnone noinline }<br>
 ; OPT-O1-DAG: Skipping pass 'Combine redundant instructions'<br>
 ; OPT-O1-DAG: Skipping pass 'Dead Store Elimination'<br>
 ; OPT-O1-DAG: Skipping pass 'Early CSE'<br>
-; OPT-O1-DAG: Skipping pass 'Early GVN Hoisting of Expressions'<br>
 ; OPT-O1-DAG: Skipping pass 'Jump Threading'<br>
 ; OPT-O1-DAG: Skipping pass 'MemCpy Optimization'<br>
 ; OPT-O1-DAG: Skipping pass 'Reassociate expressions'<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>