[PATCH] D23144: Add instruction_count MD to imported functions

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 17:57:28 PDT 2016


eraman added a comment.

In https://reviews.llvm.org/D23144#505373, @Prazek wrote:

> In https://reviews.llvm.org/D23144#505361, @eraman wrote:
>
> > I can imaging you wanting other summary information (callsite count, for example) too. Why not create a broader summary metadata and put everything there?
>
>
> I don't have plans right now of using such information. Do you have idea how helpful it could be? If not then YAGNI


Ok, fair enough, given that the importing heuristic only uses inst count currently. If and when CallGraphEdgeList is used (particularly some of callee profile counts), I would expect that it'll be useful to have that data but can be added then.


https://reviews.llvm.org/D23144





More information about the llvm-commits mailing list