[PATCH] D23144: Add instruction_count MD to imported functions

Piotr Padlewski via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 17:32:56 PDT 2016


Prazek added inline comments.

================
Comment at: include/llvm/Transforms/IPO/FunctionImport.h:32
@@ -31,2 +31,3 @@
 public:
+  using ImportThresholdTy = unsigned;
   /// Set of functions to import from a source module. Each entry is a map
----------------
eraman wrote:
> It seems unnecessary to me, but if you do this change you should use ImportThresholdTy everywhere Threshold is used.
ok maybe I will look for such places. I just hate to see code that is trying to say something using comments instead of just using code (like types)


https://reviews.llvm.org/D23144





More information about the llvm-commits mailing list