[PATCH] D23015: [ThinLTO/gold] Conservatively handle unknown GVs when internalizing

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D23015#502330, @mehdi_amini wrote:

> Do we need gold for the test here or could it be written with an LLVM tool?


Let me see if I can trigger without gold's symbol resolution

In https://reviews.llvm.org/D23015#502688, @twoh wrote:

> BTW, it seems that the original assertion failure (PR28760) doesn't happen even with r274523. Originally IRLinker::linkGlobalValueProto created a new GlobalValue with ".%d" appended to its name, but for the given example code the function returns nullptr because DoneLinkBodies is already true. Could you please double check?


I haven't tried at r274523, only at head as of yesterday. The test case included here definitely creates a GV with .%d appended (it wouldn't pass if it didn't), and it fails with the assertion if I restore that. Are you saying that the test case included here is not working when the patch is applied to r274523, or that it doesn't provoke the problem at that older revision? Or you cannot reproduce your original failure at r274523? If your original failure is reproducible at a recent revision, is it fixed by the current patch?


https://reviews.llvm.org/D23015