[PATCH] D23015: [ThinLTO/gold] Conservatively handle unknown GVs when internalizing

Taewook Oh via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 14:59:05 PDT 2016


twoh added a comment.

BTW, it seems that the original assertion failure (PR28760) doesn't happen even with r274523. Originally IRLinker::linkGlobalValueProto created a new GlobalValue with ".%d" appended to its name, but for the given example code the function returns nullptr because DoneLinkBodies is already true. Could you please double check?


https://reviews.llvm.org/D23015





More information about the llvm-commits mailing list