[PATCH] D22966: GVN-hoist: compute MSSA once per function (PR28670)

[Daniel Berlin via llvm-commits]

You should add an assert (MU->getBlock() ==
MU->getMemoryInst()->getParent()) and bugpoint it.

Are you sure you have moved the instruction at the point you create the
access?
It pulls the block from instruction->getParent() at that point :)


On Fri, Jul 29, 2016 at 9:32 PM, Sebastian Pop <sebpop at gmail.com> wrote:

> sebpop added inline comments.
>
> ================
> Comment at: lib/Transforms/Scalar/GVNHoist.cpp:311
> @@ -314,1 +310,3 @@
> +        // FIXME: MU->getBlock() does not get updated when we move the
> instruction.
> +        BasicBlock *UBB = MU->getMemoryInst()->getParent();
>          // Only analyze uses in BB.
> ----------------
> Note that if I remove this change there are tests in the test-suite that
> fail.  I will reduce a testcase for this.
>
>
> https://reviews.llvm.org/D22966
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160729/697afcd1/attachment.html>