[PATCH] D22966: GVN-hoist: compute MSSA once per function (PR28670)

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 21:32:36 PDT 2016


sebpop added inline comments.

================
Comment at: lib/Transforms/Scalar/GVNHoist.cpp:311
@@ -314,1 +310,3 @@
+        // FIXME: MU->getBlock() does not get updated when we move the instruction.
+        BasicBlock *UBB = MU->getMemoryInst()->getParent();
         // Only analyze uses in BB.
----------------
Note that if I remove this change there are tests in the test-suite that fail.  I will reduce a testcase for this.


https://reviews.llvm.org/D22966





More information about the llvm-commits mailing list