[PATCH] D22885: TargetInstrInfo: add virtual function GetInstSizeInBytes

[James Molloy via llvm-commits]

+1 to that. LGTM once that's done though.
On Wed, 27 Jul 2016 at 21:51, Matt Arsenault via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> arsenm added a comment.
>
> In https://reviews.llvm.org/D22885#498210, @SjoerdMeijer wrote:
>
> > Thanks for reviewing.
> >  I have added llvm_unreachable as the default implementation instead of
> 4.
> >  Can we keep the function name that starts with a capital letter because
> that's the function that 6 targets already implement?
>
>
> You have to touch all of them anyway to add the overrides, so might as
> well fix the name while you're at it
>
>
> https://reviews.llvm.org/D22885
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160727/f01c4fbf/attachment.html>