+1 to that. LGTM once that's done though. <br><div class="gmail_quote"><div dir="ltr">On Wed, 27 Jul 2016 at 21:51, Matt Arsenault via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">arsenm added a comment.<br>
<br>
In <a href="https://reviews.llvm.org/D22885#498210" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22885#498210</a>, @SjoerdMeijer wrote:<br>
<br>
> Thanks for reviewing.<br>
>  I have added llvm_unreachable as the default implementation instead of 4.<br>
>  Can we keep the function name that starts with a capital letter because that's the function that 6 targets already implement?<br>
<br>
<br>
You have to touch all of them anyway to add the overrides, so might as well fix the name while you're at it<br>
<br>
<br>
<a href="https://reviews.llvm.org/D22885" rel="noreferrer" target="_blank">https://reviews.llvm.org/D22885</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>