[PATCH] D22749: [ELF] - Linkerscript: Implemented SORT command

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 11:59:45 PDT 2016


grimar added a comment.

In https://reviews.llvm.org/D22749#496455, @ruiu wrote:

> I think you should be able to make this change by changing the return type of getSectionMap from `std::vector<std::pair<StringRef, ArrayRef<StringRef>>` to `std::vector<std::pair<StringRef, BaseCommand *>>`. The point is that it is not okay to add more and more code to a single function.


Yep, I thought about that, and that finally makes getSectionMap() to be very close with loop on commands, like it was before. May be getSectionMap() is itself excessive ?


https://reviews.llvm.org/D22749





More information about the llvm-commits mailing list