[PATCH] D22749: [ELF] - Linkerscript: Implemented SORT command

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 11:44:51 PDT 2016


ruiu added a comment.

I think you should be able to make this change by changing the return type of getSectionMap from `std::vector<std::pair<StringRef, ArrayRef<StringRef>>` to `std::vector<std::pair<StringRef, BaseCommand *>>`. The point is that it is not okay to add more and more code to a single function.


https://reviews.llvm.org/D22749





More information about the llvm-commits mailing list