[PATCH] D22683: [ELF] Symbol assignment within input section list

[Davide Italiano via llvm-commits]

davide added a comment.

In https://reviews.llvm.org/D22683#494525, @evgeny777 wrote:

> Adding Davide to reviewers.
>
> Davide, it looks like you handle PROVIDE (and PROVIDE_HIDDEN) inside output section definition just the same way as PROVIDE inside SECTIONS block, adding absolute values. To my understanding this is not correct, because such symbols should have values relative to section base address. Also location counter changes, while input sections are added to output section and your patch seems to ignore this, always using the value of 'Dot'.


Yes, I was thinking the same, and writing a patch. You beat me to the punch apparently, so, I'll just review it.

> Also there were the following issues in linkerscript-provide-in-section test case

> 

> a) Section name mismatch (.blah != blah)

>  b) SHF_ALLOC attribute missing on .blah

>  c) It looks like llvm-mc does not support -relocation-model attribute any longer, so now executable is being generated instead of shared object


I fixed a). Are b) and c) really problems?


https://reviews.llvm.org/D22683