[PATCH] D22683: [ELF] Symbol assignment within input section list

[Eugene Leviant via llvm-commits]

evgeny777 added a reviewer: davide.
evgeny777 removed rL LLVM as the repository for this revision.
evgeny777 updated this revision to Diff 65324.
evgeny777 added a comment.

Adding Davide to reviewers.

Davide, it looks like you handle PROVIDE (and PROVIDE_HIDDEN) inside output section definition just the same way as PROVIDE inside SECTIONS block, adding absolute values. To my understanding this is not correct, because such symbols should have values relative to section base address. Also location counter changes, while input sections are added to output section and your patch seems to ignore this, always using the value of 'Dot'.

Also there were the following issues in linkerscript-provide-in-section test case

a) Section name mismatch (.blah != blah)
b) SHF_ALLOC attribute missing on .blah
c) It looks like llvm-mc does not support -relocation-model attribute any longer, so now executable is being generated instead of shared object


https://reviews.llvm.org/D22683

Files:
  ELF/LinkerScript.cpp
  ELF/LinkerScript.h
  ELF/Writer.cpp
  test/ELF/linkerscript-symbols-synthetic.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22683.65324.patch
Type: text/x-patch
Size: 8352 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160725/ef5040b9/attachment.bin>