[PATCH] D22614: [Profile] deprecate __llvm_profile_override_default_filename [part-2]

David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 15:11:40 PDT 2016


davidxl added inline comments.

================
Comment at: test/profile/instrprof-override-filename-with-env.c:2
@@ -2,2 +1,3 @@
+// RUN: %clang_profgen=%t.bad.profraw -o %t -O3 %s
 // RUN: env LLVM_PROFILE_FILE=%t.good.profraw %run %t %t.bad.profraw
 // RUN: llvm-profdata merge -o %t.profdata %t.good.profraw
----------------
vsk wrote:
> Does this test anything useful now? Can we just delete this file?
This one still has value to test path precedence.

================
Comment at: test/profile/instrprof-override-filename.c:2
@@ -2,2 +1,3 @@
+// RUN: %clang_profgen=%t.profraw -o %t -O3 %s
 // RUN: %run %t %t.profraw
 // RUN: llvm-profdata merge -o %t.profdata %t.profraw
----------------
vsk wrote:
> Ditto, we should just be able to delete this file.
Same here -- it can serve as a basic test that = form of the option override the default.


https://reviews.llvm.org/D22614





More information about the llvm-commits mailing list