[PATCH] D22614: [Profile] deprecate __llvm_profile_override_default_filename [part-2]

[Vedant Kumar via llvm-commits]

vsk added a comment.

Minor nits.


================
Comment at: lib/profile/InstrProfilingFile.c:473
@@ -477,2 +472,3 @@
   FilenamePat = getFilenamePatFromEnv();
-  parseAndSetFilename(FilenamePat, FilenamePat ? PNS_environment : PNS_default);
+  parseAndSetFilename(
+      FilenamePat
----------------
Nit, might be easier to read as an if-stmt + ternary.

================
Comment at: test/profile/instrprof-override-filename-with-env.c:2
@@ -2,2 +1,3 @@
+// RUN: %clang_profgen=%t.bad.profraw -o %t -O3 %s
 // RUN: env LLVM_PROFILE_FILE=%t.good.profraw %run %t %t.bad.profraw
 // RUN: llvm-profdata merge -o %t.profdata %t.good.profraw
----------------
Does this test anything useful now? Can we just delete this file?

================
Comment at: test/profile/instrprof-override-filename.c:2
@@ -2,2 +1,3 @@
+// RUN: %clang_profgen=%t.profraw -o %t -O3 %s
 // RUN: %run %t %t.profraw
 // RUN: llvm-profdata merge -o %t.profdata %t.profraw
----------------
Ditto, we should just be able to delete this file.


https://reviews.llvm.org/D22614