[PATCH] D22569: [LLVM-COV] Add the coverage of lines in the summary report.

[Vedant Kumar via llvm-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: test/tools/llvm-cov/report.cpp:4
@@ -3,3 +3,3 @@
 
-// CHECK:      Filename   Regions  Miss   Cover  Functions  Executed
+// CHECK:      Filename   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover
 // CHECK-NEXT: ---
----------------
MaggieYi wrote:
> I have renamed the three ‘Miss’ heading to follow your advice. I have changed the default column widths to:
> 
> static size_t FileReportColumns[] = {25, 12, 18, 10, 12, 18, 10, 12, 18, 10};
> 
> These new ‘Miss’ columns widths are larger than the other columns. I think the report looks less nice, what do you think?
> 
IMO the report would look nicer with separators between the column names (e.g: "Filename | Regions | ... | Cover") . We can do that in a follow-up patch. I don't think re-using column names is the right answer.




https://reviews.llvm.org/D22569