[PATCH] D22569: [LLVM-COV] Add the coverage of lines in the summary report.

[Ying Yi via llvm-commits]

MaggieYi marked 2 inline comments as done.
MaggieYi added a comment.

The test in test/tools/llvm-cov/prevent_false_instantiations.h has been updated.


================
Comment at: test/tools/llvm-cov/report.cpp:4
@@ -3,3 +3,3 @@
 
-// CHECK:      Filename   Regions  Miss   Cover  Functions  Executed
+// CHECK:      Filename   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover
 // CHECK-NEXT: ---
----------------
I have renamed the three ‘Miss’ heading to follow your advice. I have changed the default column widths to:

static size_t FileReportColumns[] = {25, 12, 18, 10, 12, 18, 10, 12, 18, 10};

These new ‘Miss’ columns widths are larger than the other columns. I think the report looks less nice, what do you think?


================
Comment at: tools/llvm-cov/CoverageReport.cpp:91-92
@@ -90,3 +90,4 @@
 
-static size_t FileReportColumns[] = {25, 10, 8, 8, 10, 10};
+// Specify the default column widths.
+static size_t FileReportColumns[] = {25, 12, 18, 10, 12, 18, 10, 12, 18, 10};
 static size_t FunctionReportColumns[] = {25, 10, 8, 8, 10, 8, 8};
----------------
Yes, I have done it.


https://reviews.llvm.org/D22569