[PATCH] D22546: [Profile] Add new public API to get profile path prefix

[Xinliang David Li via llvm-commits]

On Tue, Jul 19, 2016 at 4:51 PM, Vedant Kumar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> vsk added a comment.
>
> Looks good! I just have one concern.
>
>
> ================
> Comment at: lib/profile/InstrProfiling.h:155
> @@ +154,3 @@
> + * not care about the default raw profile name. It is also useful to
> collect
> + * more than more profile data files dumped in the same directory (Online
> + * merge mode is turned on for instrumented programs with shared libs).
> ----------------
> than -> and?
>
> ================
> Comment at: lib/profile/InstrProfilingFile.c:435
> @@ +434,3 @@
> +
> +  if (lprofCurFilename.ProfilePathPrefix)
> +    return lprofCurFilename.ProfilePathPrefix;
> ----------------
> Can this give the wrong answer if it comes after a call to
> __llvm_profile_set_filename()?
>

Good catch. llvm_profile_set_filename should reset this.

David


>
>
> https://reviews.llvm.org/D22546
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160719/96f79946/attachment.html>