[PATCH] D22546: [Profile] Add new public API to get profile path prefix

[Vedant Kumar via llvm-commits]

vsk added a comment.

Looks good! I just have one concern.


================
Comment at: lib/profile/InstrProfiling.h:155
@@ +154,3 @@
+ * not care about the default raw profile name. It is also useful to collect
+ * more than more profile data files dumped in the same directory (Online
+ * merge mode is turned on for instrumented programs with shared libs).
----------------
than -> and?

================
Comment at: lib/profile/InstrProfilingFile.c:435
@@ +434,3 @@
+
+  if (lprofCurFilename.ProfilePathPrefix)
+    return lprofCurFilename.ProfilePathPrefix;
----------------
Can this give the wrong answer if it comes after a call to __llvm_profile_set_filename()?


https://reviews.llvm.org/D22546