[llvm] r275881 - AMDGPU: Remove pointless dyn_cast_or_null

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 12:00:07 PDT 2016


Author: arsenm
Date: Mon Jul 18 14:00:07 2016
New Revision: 275881

URL: http://llvm.org/viewvc/llvm-project?rev=275881&view=rev
Log:
AMDGPU: Remove pointless dyn_cast_or_null

This is already casted above so non-null

Modified:
    llvm/trunk/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp

Modified: llvm/trunk/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp?rev=275881&r1=275880&r2=275881&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp Mon Jul 18 14:00:07 2016
@@ -550,7 +550,7 @@ bool AMDGPUPromoteAlloca::collectUsesWit
     if (UseInst->getOpcode() == Instruction::PtrToInt)
       return false;
 
-    if (LoadInst *LI = dyn_cast_or_null<LoadInst>(UseInst)) {
+    if (LoadInst *LI = dyn_cast<LoadInst>(UseInst)) {
       if (LI->isVolatile())
         return false;
 
@@ -564,11 +564,10 @@ bool AMDGPUPromoteAlloca::collectUsesWit
       // Reject if the stored value is not the pointer operand.
       if (SI->getPointerOperand() != Val)
         return false;
-    } else if (AtomicRMWInst *RMW = dyn_cast_or_null<AtomicRMWInst>(UseInst)) {
+    } else if (AtomicRMWInst *RMW = dyn_cast<AtomicRMWInst>(UseInst)) {
       if (RMW->isVolatile())
         return false;
-    } else if (AtomicCmpXchgInst *CAS
-               = dyn_cast_or_null<AtomicCmpXchgInst>(UseInst)) {
+    } else if (AtomicCmpXchgInst *CAS = dyn_cast<AtomicCmpXchgInst>(UseInst)) {
       if (CAS->isVolatile())
         return false;
     }




More information about the llvm-commits mailing list