[PATCH] D22444: Clean up some comments in MathExtras.h.

[Vitaly Buka via llvm-commits]

vitalybuka added a subscriber: vitalybuka.
vitalybuka added a comment.

This probably responsible for http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/14727

Testing: 0 ..
FAIL: LLVM-Unit :: Support/SupportTests/MathExtras.minIntN (1452 of 17328)

- TEST 'LLVM-Unit :: Support/SupportTests/MathExtras.minIntN' FAILED ********************

Note: Google Test filter = MathExtras.minIntN
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from MathExtras
[ RUN      ] MathExtras.minIntN
/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/Support/MathExtras.h:340:10: runtime error: negation of -9223372036854775808 cannot be represented in type 'long'; cast to an unsigned type to negate this value to itself

  #0 0x4fb9e3 in llvm::minIntN(long) /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/Support/MathExtras.h:340:10
  #1 0x4e9583 in (anonymous namespace)::MathExtras_minIntN_Test::TestBody() /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/unittests/Support/MathExtrasTest.cpp:132:3
  #2 0x6c22a9 in testing::Test::Run() /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2161:5
  #3 0x6c2d13 in testing::TestInfo::Run() /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2309:11
  #4 0x6c3432 in testing::TestCase::Run() /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2416:28
  #5 0x6c8703 in testing::internal::UnitTestImpl::RunAllTests() /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:4207:43
  #6 0x6d4f51 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:2142:12
  #7 0x6c83ae in testing::UnitTest::Run() /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/googletest/src/gtest.cc:3841:10
  #8 0x6ba984 in main /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/utils/unittest/UnitTestMain/TestMain.cpp:48:10
  #9 0x7f23b4d18f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
  #10 0x4191b6 in _start (/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm_build_ubsan/unittests/Support/SupportTests+0x4191b6)

********************

Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 97.53s

********************

Failing Tests (1):

  LLVM-Unit :: Support/SupportTests/MathExtras.minIntN


Repository:
  rL LLVM

https://reviews.llvm.org/D22444