[PATCH] D22418: COFF: Implement /reproduce flag.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: COFF/Driver.cpp:313
@@ +312,3 @@
+    Cpio.reset(check(CpioFile::create(Arg->getValue()),
+                     Twine("/reproduce: failed to open ") + Arg->getValue() +
+                         ".cpio"));
----------------
You might be able to remote Twine().

================
Comment at: COFF/Error.h:36
@@ +35,3 @@
+template <class T> T check(ErrorOr<T> EO) {
+  if (EO)
+    return std::move(*EO);
----------------
Swap the condition (`if (!EO)`) for the consistency with other functions in this file.

================
Comment at: COFF/InputFiles.cpp:99
@@ +98,3 @@
+      check(C.getMemoryBufferRef(),
+            Twine("Could not get the buffer for the member defining symbol ") +
+                Sym->getName());
----------------
Remove Twine?

================
Comment at: ELF/Driver.cpp:273
@@ +272,3 @@
+    Cpio.reset(check(CpioFile::create(Path),
+                     Twine("--reproduce: failed to open ") + Path + ".cpio"));
+    Cpio->append("response.txt", createResponseFile(Args));
----------------
Twine?


https://reviews.llvm.org/D22418