[PATCH] D22418: COFF: Implement /reproduce flag.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 11:50:29 PDT 2016


ruiu added inline comments.

================
Comment at: lib/Core/Reproduce.cpp:83
@@ +82,3 @@
+    return EC;
+  path::remove_dots(Abs, /*remove_dot_dot=*/true);
+
----------------
It seems that if getcwd (or equivalent) failed, the system is really broken and can't do anything sane. Should we just swallow an error and returns the original string in case of an error?


https://reviews.llvm.org/D22418





More information about the llvm-commits mailing list