[PATCH] D21232: Add attribute noreturn to functions that throw

[Aditya Kumar via llvm-commits]

hiraditya added a comment.

In https://reviews.llvm.org/D21232#458989, @mclow.lists wrote:

> I think a macro would be better here; something like `LIBCPP_NORETURN_IF_NO_EXCEPTIONS` rather than putting `__attribute__((__noreturn__))` everywhere.
>
> Besides, it makes it clear *why* these bits are being marked `noreturn`.
>
> What do you think?


Hi Marshall,
I have updated the macro name and addressed the suggestions of Sebastian, and Eric. Please accept the patch if it looks good to you.

Thanks,


https://reviews.llvm.org/D21232