[PATCH] D22163: X86: Avoid implicit iterator conversions, NFC

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 19:13:33 PDT 2016


dexonsmith added a comment.

Fast ping, since this and the PowerPC patch are the only remaining blockers to removing the implicit MachineInstrBundleIterator::operator MachineInstr*(), and I'd like to prevent bitrot in the rest of the backend.

Note that I don't necessarily need X86 or even backend expertise for this review; I'd just appreciate someone double-checking that I didn't dereference an end-iterator somewhere or something like that.  Is anyone willing to give this a quick read?


http://reviews.llvm.org/D22163





More information about the llvm-commits mailing list