[PATCH] D21982: WIP: Implement a per-thread inmemory log

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 02:04:44 PDT 2016


dberris marked an inline comment as done.

================
Comment at: lib/xray/xray_inmemory_log.cc:119
@@ +118,3 @@
+      if (Written == -1) {
+        // FIXME: Failed writing, bail out.
+        printf("Failed to write; errno = %d", errno);
----------------
majnemer wrote:
> Should we handle `errno == EINTR`?
Yes, and refactor this a bit so we do the right thing both times. :)


http://reviews.llvm.org/D21982





More information about the llvm-commits mailing list