majnemer added inline comments. ================ Comment at: lib/xray/xray_inmemory_log.cc:119 @@ +118,3 @@ + if (Written == -1) { + // FIXME: Failed writing, bail out. + printf("Failed to write; errno = %d", errno); ---------------- Should we handle `errno == EINTR`? http://reviews.llvm.org/D21982