[PATCH] D21424: StackColoring for SafeStack.

[Peter Collingbourne via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/CodeGen/SafeStackColoring.h:24
@@ +23,3 @@
+/// Compute live ranges of allocas.
+/// Live ranges are represented a sets of "interesting" instructions, which are
+/// defined as instructions that may start or end an alloca's lifetime. These
----------------
Nitpick: "as sets".

================
Comment at: lib/CodeGen/SafeStackLayout.h:19
@@ +18,3 @@
+class SafeStackLayout {
+  unsigned MaxAlignment;
+
----------------
I'm partial to the pattern of moving pass implementation details into a namespace named after the pass, so maybe something like `llvm::safestack::StackLayout`?

But I'd be happy with whatever you decide to do here.


Repository:
  rL LLVM

http://reviews.llvm.org/D21424