[PATCH] D21424: StackColoring for SafeStack.

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/CodeGen/SafeStackColoring.h:58
@@ +57,3 @@
+
+  /// Number of interesting instructions.
+  int NumInst;
----------------
pcc wrote:
> Define "interesting"
I've added a few words in the class-level comment.

================
Comment at: lib/CodeGen/SafeStackLayout.h:18
@@ +17,3 @@
+/// Compute the layout of an unsafe stack frame.
+class SafeStackLayout {
+  unsigned MaxAlignment;
----------------
pcc wrote:
> Is this the right name for this class? The name suggests that it handles layout for the safe stack.
Would you prefer UnsafeStackLayout?
There is nothing in this class that deals with the notion of safe or unsafe alloca - it's frame layout code for the "SafeStack" feature, and I like that it starts with "SafeStack".


Repository:
  rL LLVM

http://reviews.llvm.org/D21424