[PATCH] D21681: [ELF] - Implemented support of default/non-default symbols versions

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/SymbolTable.cpp:166
@@ -165,1 +165,3 @@
 
+// To properly export dynamic symbol we should set its version as local or
+// global unversioned. Later scanVersionScript() will scan through version
----------------
  // A symbol version may be included in a symbol name as a prefix after '@'.
  // This function parses that part and returns a version ID number.

================
Comment at: ELF/Symbols.cpp:106
@@ +105,3 @@
+  assert(!isLocal());
+  StringRef N = StringRef(Name.S, Name.Len);
+  if (!symbol()->VersionedName)
----------------
`N` is usually a number, so name this `S`.

================
Comment at: ELF/Symbols.cpp:109
@@ +108,3 @@
+    return N;
+  return N.substr(0, N.find("@"));
+}
----------------
"@" -> '@'


http://reviews.llvm.org/D21681