[PATCH] D21681: [ELF] - Implemented support of default/non-default symbols versions

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/SymbolTable.cpp:166
@@ -165,1 +165,3 @@
 
+static uint16_t getVersionId(Symbol *Sym, StringRef Name) {
+  uint16_t Version =
----------------
ruiu wrote:
> This function needs a function comment as it is not obvious what this is for.
Done.

================
Comment at: ELF/SymbolTable.cpp:172
@@ +171,3 @@
+  if (VersionBegin == StringRef::npos)
+    return Version;
+
----------------
ruiu wrote:
> Remove `Version` variable and inline `Config->VersionScriptGlobalByDefault ? ...` here.
Done.

================
Comment at: ELF/SymbolTable.cpp:189
@@ +188,3 @@
+  }
+  error("symbol " + Name.substr(0, Name.find('@')) + " has undefined version " +
+        VersionName);
----------------
ruiu wrote:
> I wouldn't strip '@' and following characters because it is what users want to know.
Done.

================
Comment at: ELF/SymbolTable.cpp:191
@@ +190,3 @@
+        VersionName);
+  return Version;
+}
----------------
ruiu wrote:
> Since this is a dummy value, return something meaningless such as just 0.
Done.


http://reviews.llvm.org/D21681