[PATCH] D21488: [polly] Fix some Clang-tidy and Include What You Use warnings; other minor fixes

[Eugene Zelenko via llvm-commits]

Eugene.Zelenko added a comment.

For source files I modified, I run Clang-tidy with next arguments (I assume this as minor clean-ups):

-checks="-*,misc-suspicious-string-compare,misc-unused-using-decls,modernize-redundant-void-arg,modernize-deprecated-headers,modernize-use-bool-literals,modernize-use-nullptr,modernize-use-override,readability-container-size-empty,readability-redundant-control-flow,readability-redundant-string-cstr,readability-redundant-string-init,readability-simplify-boolean-expr,readability-redundant-string-init" -config="{CheckOptions: [{key: misc-suspicious-string-compare.WarnOnLogicalNotComparison , value: '1'}]}" -header-filter=".*"

So Polly code base is very clean. I caught one readability-container-size-empty warning in lib/Analysis/ScopDetection.cpp.

I fixed namespace ending comments manually and I used comment form prevailing in LLVM/Clang source files.

I applied Include What You Use manually, since sometimes it provide false positives or stuff is used implicitly, so it's not very clear how correct suggestions were.

Extra semicolon could be caught with -Wextra-semi, but I found them manually.


Repository:
  rL LLVM

http://reviews.llvm.org/D21488