[PATCH] D21488: [polly] Fix some Clang-tidy and Include What You Use warnings; other minor fixes

[Tobias Grosser via llvm-commits]

grosser added a comment.

In http://reviews.llvm.org/D21488#463490, @Eugene.Zelenko wrote:

> Frankly, it'll be better to commit all changes ones without repeating same job.
>
> But I could describe all changes in commit message, so other people could learn.


Hi Eugene,

I still believe that separating commits out into independent changes makes a lot of sense, as otherwise understanding this large set of changes is difficult as each change needs to be matched to the specific improvement that you performed and it is unclear which changes have been performed automatically and where you manually changed the code.  In general rebasing and splitting patches should not be too difficult, especially as most of these changes are performed with automatic tools. I already started in r273435 with the 'modern-use-nullptr' fixes, which were indeed very easy to apply with clang-tidy. I also split-off two independent manual changes in r273436 and r273437. If you feel motivated to continue this work, that would be great. Otherwise, it would be great if you could give me the necessary information/command line flags to reproduce your changes. I tried to use llvm-namespace-comment to reproduce the namespace changes, but the suggested line endings are different to the ones proposed in your patch. I get for example "} // namespace" instead of "} // end anonymous namespace" and "} // namespace polly" instead of "} // end namespace polly". I used the latest version of clang-tidy with -checks='-*,llvm-namespace-comment'.

Best,
Tobias


Repository:
  rL LLVM

http://reviews.llvm.org/D21488