[PATCH] D21553: Do not require __STDC_LIMIT_MACROS and others

Paweł Bylica via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 04:01:59 PDT 2016


chfast added a comment.

In http://reviews.llvm.org/D21553#463304, @jyknight wrote:

> Not requiring the defines is good; removing the defines in the build files is not. We still want to be able to build out of the box on systems with this known brokenness.


Can we identify such broken systems in the first place?

I do care about exported cmake variables, especially LLVM_DEFINITIONS and it currently looks like:

  set(LLVM_DEFINITIONS "-D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS")

I guess nobody knows any more why and where they are needed.


http://reviews.llvm.org/D21553





More information about the llvm-commits mailing list