[PATCH] D21553: Do not require __STDC_LIMIT_MACROS and others
James Y Knight via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 21 08:24:35 PDT 2016
jyknight added a comment.
Not requiring the defines is good; removing the defines in the build files is not. We still want to be able to build out of the box on systems with this known brokenness.
================
Comment at: cmake/modules/HandleLLVMOptions.cmake:555-557
@@ -554,5 +554,1 @@
-add_llvm_definitions( -D__STDC_CONSTANT_MACROS )
-add_llvm_definitions( -D__STDC_FORMAT_MACROS )
-add_llvm_definitions( -D__STDC_LIMIT_MACROS )
-
----------------
Keep these.
================
Comment at: utils/vim/vimrc:111
@@ -110,3 +110,2 @@
\ "-x","c++",
- \ "-D__STDC_LIMIT_MACROS=1","-D__STDC_CONSTANT_MACROS=1",
\ "-Iinclude" ]
----------------
Probably leave this too.
http://reviews.llvm.org/D21553
More information about the llvm-commits
mailing list