[llvm] r273245 - Revert "Change RelaxELFRelocations for llc."

[James Y Knight via llvm-commits]

Author: jyknight
Date: Tue Jun 21 00:40:41 2016
New Revision: 273245

URL: http://llvm.org/viewvc/llvm-project?rev=273245&view=rev
Log:
Revert "Change RelaxELFRelocations for llc."

This reverts commit r273019.

>From email I sent to list:
> I don't think this makes sense. Either the linker you're using supports
> this feature, or it doesn't. Having it enabled for llc if your linker
> doesn't support it is not fun.
>
> Further note that this also affects basically all other code using llvm
> libraries -- other than Clang, which explicitly sets it back to false by
> default, unless you set the ENABLE_X86_RELAX_RELOCATIONS cmake flag to
> true.
>
> If you want to enable the relax mode across all llvm tools in some
> circumstances, I think it should be via moving the cmake flag from clang
> down into llvm.
>
> I'm going to revert this commit, since I both think it intrinsically
> doesn't make sense to do this, and because it's breaking some of our
> tools.

Removed:
    llvm/trunk/test/CodeGen/X86/relax-reloc.ll
Modified:
    llvm/trunk/include/llvm/Target/TargetOptions.h

Modified: llvm/trunk/include/llvm/Target/TargetOptions.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetOptions.h?rev=273245&r1=273244&r2=273245&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Target/TargetOptions.h (original)
+++ llvm/trunk/include/llvm/Target/TargetOptions.h Tue Jun 21 00:40:41 2016
@@ -98,7 +98,7 @@ namespace llvm {
           GuaranteedTailCallOpt(false), StackAlignmentOverride(0),
           StackSymbolOrdering(true), EnableFastISel(false), UseInitArray(false),
           DisableIntegratedAS(false), CompressDebugSections(false),
-          RelaxELFRelocations(true), FunctionSections(false),
+          RelaxELFRelocations(false), FunctionSections(false),
           DataSections(false), UniqueSectionNames(true), TrapUnreachable(false),
           EmulatedTLS(false), FloatABIType(FloatABI::Default),
           AllowFPOpFusion(FPOpFusion::Standard), Reciprocals(TargetRecip()),

Removed: llvm/trunk/test/CodeGen/X86/relax-reloc.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/relax-reloc.ll?rev=273244&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/relax-reloc.ll (original)
+++ llvm/trunk/test/CodeGen/X86/relax-reloc.ll (removed)
@@ -1,15 +0,0 @@
-; RUN: llc %s -o %t.o -filetype=obj -relocation-model=pic
-; RUN: llvm-readobj -r %t.o | FileCheck %s
-; CHECK:      Section ({{.}}) .rela.text {
-; CHECK-NEXT:   0x3 R_X86_64_REX_GOTPCRELX a 0xFFFFFFFFFFFFFFFC
-; CHECK-NEXT: }
-
-target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
-target triple = "x86_64-unknown-linux-gnu"
-
- at a = external global i32
-
-define i32 @f() {
-  %t = load i32, i32* @a
-  ret i32 %t
-}