[PATCH] D21393: [pdbdump] Verify LF_{CLASS, ENUM, INTERFACE, STRUCTURE, UNION} records with different hash function.

[Rui Ueyama via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL272930: [codeview] Use hashBufferV8 to verify all type records. (authored by ruiu).

Changed prior to commit:
  http://reviews.llvm.org/D21393?vs=60978&id=61002#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D21393

Files:
  llvm/trunk/lib/DebugInfo/PDB/Raw/TpiStream.cpp

Index: llvm/trunk/lib/DebugInfo/PDB/Raw/TpiStream.cpp
===================================================================
--- llvm/trunk/lib/DebugInfo/PDB/Raw/TpiStream.cpp
+++ llvm/trunk/lib/DebugInfo/PDB/Raw/TpiStream.cpp
@@ -65,22 +65,20 @@
 TpiStream::~TpiStream() {}
 
 // Computes a hash for a given TPI record.
-template <typename T> static uint32_t getTpiHash(T &Rec) {
+template <typename T>
+static uint32_t getTpiHash(T &Rec, const CVRecord<TypeLeafKind> &RawRec) {
   auto Opts = static_cast<uint16_t>(Rec.getOptions());
 
-  // We don't know how to calculate a hash value for this yet.
-  // Currently we just skip it.
-  if (Opts & static_cast<uint16_t>(ClassOptions::ForwardReference))
-    return 0;
+  bool ForwardRef =
+      Opts & static_cast<uint16_t>(ClassOptions::ForwardReference);
+  bool Scoped = Opts & static_cast<uint16_t>(ClassOptions::Scoped);
+  bool UniqueName = Opts & static_cast<uint16_t>(ClassOptions::HasUniqueName);
 
-  if (!(Opts & static_cast<uint16_t>(ClassOptions::Scoped)))
+  if (!ForwardRef && !Scoped)
     return hashStringV1(Rec.getName());
-
-  if (Opts & static_cast<uint16_t>(ClassOptions::HasUniqueName))
+  if (!ForwardRef && UniqueName)
     return hashStringV1(Rec.getUniqueName());
-
-  // This case is not implemented yet.
-  return 0;
+  return hashBufferV8(RawRec.RawData);
 }
 
 namespace {
@@ -102,15 +100,16 @@
   Error visitEnum(EnumRecord &Rec) override { return verify(Rec); }
   Error visitUnion(UnionRecord &Rec) override { return verify(Rec); }
 
-  Error visitTypeEnd(const CVRecord<TypeLeafKind> &Record) override {
+  Error visitTypeBegin(const CVRecord<TypeLeafKind> &Rec) override {
     ++Index;
+    RawRecord = &Rec;
     return Error::success();
   }
 
 private:
   template <typename T> Error verify(T &Rec) {
-    uint32_t Hash = getTpiHash(Rec);
-    if (Hash && Hash % NumHashBuckets != HashValues[Index])
+    uint32_t Hash = getTpiHash(Rec, *RawRecord);
+    if (Hash % NumHashBuckets != HashValues[Index])
       return make_error<RawError>(raw_error_code::invalid_tpi_hash);
     return Error::success();
   }
@@ -125,8 +124,9 @@
   }
 
   FixedStreamArray<support::ulittle32_t> HashValues;
+  const CVRecord<TypeLeafKind> *RawRecord;
   uint32_t NumHashBuckets;
-  uint32_t Index = 0;
+  uint32_t Index = -1;
 };
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21393.61002.patch
Type: text/x-patch
Size: 2306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160616/1256993e/attachment.bin>